Skip to content

fix: Remove dead, stale DETECTORS list in cli.py (#1) - #16

Closed
IronLad123 wants to merge 3 commits into
bamdadd:mainfrom
IronLad123:fix/remove-dead-detectors-constant
Closed

fix: Remove dead, stale DETECTORS list in cli.py (#1)#16
IronLad123 wants to merge 3 commits into
bamdadd:mainfrom
IronLad123:fix/remove-dead-detectors-constant

Conversation

@IronLad123

Copy link
Copy Markdown
Contributor

Closes #1

Summary

Removes the unused, module-level DETECTORS = [...] constant at src/taintline/cli.py:11.

Rationale

  • The constant was dead code (never read or imported anywhere in src/, tests/, demo/, or docs/).
  • It was stale — listing 5 detectors when the authoritative registry (src/taintline/detectors/__init__.py:ALL) contains 6 (missing budget-overrun).
  • CLI --help text already dynamically derives the detector list from ALL.

Verification

  • grep -rn 'DETECTORS' src returns no hits.
  • pytest: all 49 tests pass cleanly (49 passed in 1.05s).
  • ruff check src/taintline/cli.py: clean (0 issues).

@bamdadd

bamdadd commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Thank you @IronLad123 for spotting and removing this dead, stale DETECTORS constant. The authoritative registry in detectors/__init__.py is now the single source of truth, and the CLI help already derives from it. Squash-merged to main as 2742abc. Much appreciated!

@bamdadd

bamdadd commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Merged via 2742abc. Thanks again!

@bamdadd bamdadd closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead, stale DETECTORS list in cli.py

2 participants